[webgpu] Fix access mode for storage address space #6607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BUG Due to WGSL Spec(https://www.w3.org/TR/WGSL/#address-space), storage address space only supported read_write and read access modes.
Contributor
Author
qjia7
approved these changes
Jul 7, 2022
Contributor
qjia7
left a comment
qjia7
left a comment
There was a problem hiding this comment.
LGTM, thanks.
Here https://github.com/tensorflow/tfjs/blob/master/tfjs-backend-webgpu/src/matmul_packed_webgpu.ts#L180 you missed one to change let -> const in your last PR. Can you add it in this PR too?
Contributor
Author
|
@qjia7 Done.PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG
Due to WGSL Spec(https://www.w3.org/TR/WGSL/#address-space), storage
address space only supported read_write and read access modes.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is